Fix the surrounding loop is unconditionally terminated (SA4004)

[Honny1]

This PR fixes the surrounding loop is unconditionally terminated warning (SA4004) found by golangci when the staticcheck linter is enabled.

Partially fixes:

• Consider allowing more linters #1579

[rhatdan]

LGTM

[mtrmac]

@giuseppe @ktock “Additional layer stores” support multiple stores, but apparently the code was only able to work with the first one, since the very start of the feature ( 64f0181 ).

What do you think about simplifying to only support one store? Admittedly that would not help simplify the codebase all that much, ALS is AFAICS only a feature within this driver and ~this one loop — and instead, we would need to add even more code to reject multiple stores when parsing options.

Either way, we seem not to have tests sufficiently covering the feature.

[ktock]

What do you think about simplifying to only support one store?

SGTM

[mtrmac]

LGTM, just a non-blocking stylistic nit.

Please squash follow-on fixes instead of leaving the original versions of commits in the PR in the history.

[rhatdan]

/approve
/lgtm
Thanks @Honny1

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mtrmac]

/lgtm