Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't silently ignore errors decoding mountpoints.json #1606

Merged
merged 1 commit into from
May 22, 2023

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented May 19, 2023

Other Unmarshal calls have already been modified similarly.

This “should not matter” in practice, but we are seeing incorrect mount counts in containers/podman#17216 .

@rhatdan
Copy link
Member

rhatdan commented May 19, 2023

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg vrothberg merged commit 9e425af into containers:main May 22, 2023
@mtrmac mtrmac deleted the unmarshal-error branch May 22, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants