Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update c/image with https://github.com/containers/image/pull/1944 #1995

Merged
merged 2 commits into from
May 9, 2023

Conversation

mtrmac
Copy link
Contributor

@mtrmac mtrmac commented May 5, 2023

... to update github.com/opencontainers/image-spec to v1.1.0-rc3.

Replaces #1984 .

... to update github.com/opencontainers/image-spec to v1.1.0-rc3.

Signed-off-by: Miloslav Trmač <[email protected]>
Currently it uses golang-1.18.7-1.fc36.x86_64 ; we need 1.19,
and the current version of the base image has golang-1.20.3-1.fc38.x86_64
 .

Signed-off-by: Miloslav Trmač <[email protected]>
@mtrmac
Copy link
Contributor Author

mtrmac commented May 5, 2023

The ostree-rs-ext test is failing because it is using golang-1.18.7-1.fc36.x86_64, but the new code requires Go 1.19.

Meanwhile, Go https://src.fedoraproject.org/rpms/golang lists 1.19.8 as available.

It seems that the base image of the container we use is more fresh, so I’m trying to trigger an update.

@rhatdan
Copy link
Member

rhatdan commented May 6, 2023

LGTM

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg vrothberg merged commit 6836ab3 into containers:main May 9, 2023
@mtrmac mtrmac deleted the c-image-for-image-spec branch May 9, 2023 14:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants