[skip-ci] Packit/TMT: Run gating tests #1960
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,7 +31,7 @@ jobs: | |
| notifications: &copr_build_failure_notification | ||
| failure_comment: | ||
| message: "Ephemeral COPR build failed. @containers/packit-build please check." | ||
| targets: &fedora_copr_targets | ||
| - fedora-development-x86_64 | ||
| - fedora-development-aarch64 | ||
| - fedora-latest-x86_64 | ||
|
|
@@ -43,7 +43,7 @@ jobs: | |
| enable_net: true | ||
|
|
||
| - job: copr_build | ||
| trigger: ignore | ||
|
There was a problem hiding this comment. Is this an intentional part of the PR? It’s not obvious to me that changes to tests should affect whether we test building. |
||
| packages: [skopeo-eln] | ||
| notifications: *copr_build_failure_notification | ||
| targets: | ||
|
|
@@ -59,7 +59,7 @@ jobs: | |
| trigger: pull_request | ||
| packages: [skopeo-centos] | ||
| notifications: *copr_build_failure_notification | ||
| targets: ¢os_copr_targets | ||
| - centos-stream-9-x86_64 | ||
| - centos-stream-9-aarch64 | ||
| - centos-stream-10-x86_64 | ||
|
|
@@ -88,6 +88,39 @@ jobs: | |
| project: podman-next | ||
| enable_net: true | ||
|
|
||
| # Tests on Fedora | ||
| - job: tests | ||
| trigger: pull_request | ||
| packages: [skopeo-fedora] | ||
| notifications: &test_failure_notification | ||
| failure_comment: | ||
| message: "Tests failed. @containers/packit-build please check." | ||
| tmt_plan: /plans/upstream | ||
| targets: | ||
|
There was a problem hiding this comment. Note to self: Per https://packit.dev/docs/configuration/upstream/tests#required-parameters , There was a problem hiding this comment. Maybe worth a comment in the file? Especially when it differs from the build job semantics. |
||
| - fedora-development | ||
| - fedora-latest | ||
| - fedora-latest-stable | ||
| - fedora-40 | ||
| tf_extra_params: | ||
| environments: | ||
| - artifacts: | ||
| - type: repository-file | ||
| id: https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/repo/fedora-$releasever/rhcontainerbot-podman-next-fedora-$releasever.repo | ||
|
|
||
| # Tests on CentOS Stream | ||
| - job: tests | ||
| trigger: pull_request | ||
| packages: [skopeo-centos] | ||
| notifications: *test_failure_notification | ||
| targets: | ||
| - centos-stream-9 | ||
| - centos-stream-10 | ||
| tf_extra_params: | ||
| environments: | ||
| - artifacts: | ||
| - type: repository-file | ||
| id: https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/repo/centos-stream-$releasever/rhcontainerbot-podman-next-centos-stream-$releasever.repo | ||
|
|
||
| # Sync to Fedora | ||
| - job: propose_downstream | ||
| trigger: release | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,10 @@ | ||
| #!/bin/bash | ||
| set -exo pipefail | ||
|
|
||
| if [[ ! -f /usr/bin/skopeo ]]; then | ||
|
There was a problem hiding this comment. AFAICS this introduces a risk that we are going to test some pre-existing system binary, not the one we just built (or, see elsewhere about |
||
| make PREFIX=/usr install | ||
| fi | ||
|
|
||
| echo "cd ./integration;" go test $TESTFLAGS ${BUILDTAGS:+-tags "$BUILDTAGS"} | ||
| cd ./integration | ||
| go test $TESTFLAGS ${BUILDTAGS:+-tags "$BUILDTAGS"} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| require: | ||
| - make | ||
| - podman-docker | ||
|
|
||
| /unit: | ||
| tag: upstream | ||
| summary: Run unit test | ||
| test: make -C ../.. test-unit | ||
|
|
||
| /validate: | ||
| tag: upstream | ||
| summary: Run validate test | ||
| test: make -C ../.. tools validate |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| require: | ||
| - golang | ||
| - make | ||
| - podman | ||
| - skopeo | ||
|
There was a problem hiding this comment. Is this requiring some other Skopeo binary than the one we are testing? Or does that guarantee to use the one from … and if this is the one we should be testing, how does that |
||
|
|
||
| duration: 30m | ||
|
|
||
| tag: [ upstream, downstream ] | ||
| summary: Run integration tests | ||
| test: make -C ../.. test-integration | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| discover: | ||
| how: fmf | ||
| execute: | ||
| how: tmt | ||
|
|
||
| /upstream: | ||
| summary: Run tests on upstream PRs | ||
| discover+: | ||
| filter: tag:upstream | ||
| adjust+: | ||
| enabled: false | ||
| when: initiator is not defined or initiator != packit | ||
|
|
||
| /downstream: | ||
| summary: Run tests on bodhi / errata and dist-git PRs | ||
| discover+: | ||
| filter: tag:downstream | ||
| adjust+: | ||
| enabled: false | ||
| when: initiator == packit |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This, and
centos_copr_targets, seem to be unused. Is that intentional?