Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoPR: Autobuild rpm on rhcontainerbot/podman-next #1681

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Jun 16, 2022

The new file skopeo.spec.rpkg along with a webhook will automatically
build rpms on every PR merge on the main branch.

Run rpkg local or make rpm to generate the rpm.

Known issue: Doesn't yet build for EL8 environments.

Signed-off-by: Lokesh Mandvekar [email protected]

@rhatdan @vrothberg @mtrmac PTAL

I have added the webhook already, so merging this should trigger an rpm build on the copr.

The new file `skopeo.spec.rpkg` along with a webhook will automatically
build rpms on every PR merge on the main branch.

Run `rpkg local` or `make rpm` to generate the rpm.

Known issue: Doesn't yet build for EL8 environments.

Signed-off-by: Lokesh Mandvekar <[email protected]>
Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Is this related to #1661 ? I’m rather confused about how that is supposed to work — the original issue is that building cross-architecture containers using qemu-user-static takes too long, and the improvement is to first build RPMs and then build containers using those RPMs, in two separate stages and systems?

How is that faster? Is there some significant infrastructure difference, like the RPM builders being native, or the hardware being faster/cheaper?

Or is this completely unrelated to #1681?

@@ -0,0 +1,126 @@
# For automatic rebuilds in COPR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A totally non-blocking it: Would it be (without extra hassle) possible to move this somewhere to contrib? We don’t really want users to build their own RPMs, and that’s where the container image descriptions are (admittedly contrib is not a great name for “our own build infrastructure that other users shouldn’t need to touch”).

OTOH I see podman.spec.rpkg in the same place, and that consistency is certainly valuable. So entirely up to you.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check if that's doable. IIRC, this file is expected in the main dir, but let me confirm..

@lsm5
Copy link
Member Author

lsm5 commented Jun 16, 2022

Thanks.

Is this related to #1661 ? I’m rather confused about how that is supposed to work — the original issue is that building cross-architecture containers using qemu-user-static takes too long, and the improvement is to first build RPMs and then build containers using those RPMs, in two separate stages and systems?

How is that faster? Is there some significant infrastructure difference, like the RPM builders being native, or the hardware being faster/cheaper?

Or is this completely unrelated to #1681?

Completely unrelated, unless @cevich wants it to be. This is mainly a way to let users to fetch RPMs built using the latest merged upstream code. With the current setup, this will only build RPMs post-merge. There might be ways to trigger it pre-merge for testing purposes but I don't yet have a good way to do it without polluting the CoPR with a ridiculous amount of builds.

@cevich
Copy link
Member

cevich commented Jun 16, 2022

Ya, what @lsm5 said. It's faster at container-image build time, since we're just installing a skopeo rpm instead of all the nubbins needed to build the binary under emulation. The way Lokesh has it wired, anytime main changes his COPR build fires. So it's also handy because he'll know right away if a merged PR breaks RPM builds on any supported architecture.

@mtrmac
Copy link
Contributor

mtrmac commented Jun 16, 2022

This is mainly a way to let users to fetch RPMs built using the latest merged upstream code.

Thanks. I’ll entirely defer to your expertise, then — feel free to merge as appropriate.

@lsm5
Copy link
Member Author

lsm5 commented Jun 16, 2022

Thanks @mtrmac. Merging ..

@lsm5 lsm5 merged commit 3738854 into containers:main Jun 16, 2022
@lsm5 lsm5 deleted the copr-rpkg branch June 16, 2022 19:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants