Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete all containers and pods between tests #9699

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Delete all containers and pods between tests #9699

merged 1 commit into from
Mar 12, 2021

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Mar 11, 2021

New tearDown() deletes all pods and containers between tests

Signed-off-by: Jhon Honce [email protected]

@jwhonce
Delete all containers and pods between tests
92a8d69 
New tearDown() deletes all pods and containers between tests

Signed-off-by: Jhon Honce <[email protected]>
@jwhonce jwhonce added the kind/test-flake Categorizes issue or PR as related to test flakes. label Mar 11, 2021
@jwhonce jwhonce requested review from cevich and rhatdan March 11, 2021 21:27
@jwhonce jwhonce self-assigned this Mar 11, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2021
@rhatdan
Copy link
Member

rhatdan commented Mar 11, 2021

LGTM

@TomSweeneyRedHat
Copy link
Member

@jwhonce something is not making the test system very happy....

@cevich
Copy link
Member

cevich commented Mar 12, 2021

@jwhonce something is not making the test system very happy....

Okay! Well! That's my signal to take PTO on Friday 😄

(I restarted the failed tests, appeared like Google-storage or network flakes, strangely enough)

cevich
cevich approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, it LGTM, and I actually think I understand it 😁 Note: I didn't spend any time looking at the re-formatting changes, I'm assuming those are all kosher, and if not you understand how to fix them 😄

test/apiv2/rest_api/__init__.py
sys.stdout.write("\nRun Stdout:\n" + e.stdout.decode("utf-8"))
if e.stderr:
sys.stderr.write("\nRun Stderr:\n" + e.stderr.decode("utf-8"))
raise
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah that will be helpful, thanks!

test/apiv2/rest_api/test_rest_v2_0_0.py
super().tearDown()

TestApi.podman.run("pod", "rm", "--all", "--force", check=True)
TestApi.podman.run("rm", "--all", "--force", check=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is totally fine. Crap can get left behind for any number of reasons, not all should cause test failures. The time spent doing this will more than outweigh the aggravation and time of re-running the test b/c of flakes.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cevich
Copy link
Member

cevich commented Mar 12, 2021

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2021
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2021
@jwhonce
Copy link
Member Author

jwhonce commented Mar 12, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2021
@openshift-merge-robot openshift-merge-robot merged commit 0d6673e into containers:master Mar 12, 2021
@cevich cevich mentioned this pull request Mar 15, 2021
Closed
This was referenced Mar 15, 2021
Closed
Merged
@edsantiago edsantiago mentioned this pull request Mar 24, 2021
Closed
@jwhonce jwhonce deleted the wip/tests branch June 30, 2021 16:10
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cevich cevich cevich approved these changes

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@jwhonce jwhonce

@cevich cevich

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/test-flake Categorizes issue or PR as related to test flakes. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jwhonce @rhatdan @TomSweeneyRedHat @cevich @openshift-ci-robot @openshift-merge-robot