Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO TESTS NEEDED] podman-remote build does not support volumes #9651

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Mar 7, 2021

Remove --volume option from podman-remote since it is
not supported, also add information to podman-build man page
indicating options not supported over remote connections.

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2021
@rhatdan rhatdan changed the title podman-remote build does not support volumes [NO TESTS NEEDED] podman-remote build does not support volumes Mar 7, 2021
@@ -86,7 +86,7 @@ resulting image's configuration.
#### **--cache-from**

Images to utilize as potential cache sources. Podman does not currently support
caching so this is a NOOP.
caching so this is a NOOP. (Not available for remote commands)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest "This option is not available with the remote Podman client"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have this comment all over the podman-run and podman-create man page, so I will make the change everywhere. Want to get @TomSweeneyRedHat agreement though so we don't bikeshed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mheon's suggestion SGTM

@rhatdan rhatdan force-pushed the volume branch 2 times, most recently from 14b9453 to 37dd5cf Compare March 8, 2021 17:09
Remove --volume option from podman-remote since it is
not supported, also add information to podman-build man page
indicating options not supported over remote connections.

Signed-off-by: Daniel J Walsh <[email protected]>
@jwhonce
Copy link
Member

jwhonce commented Mar 8, 2021

LGTM

@TomSweeneyRedHat
Copy link
Member

Hmm, I could have sworn I LGTM'd this earlier, I'll do so now.
LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2021
@openshift-merge-robot openshift-merge-robot merged commit 789d579 into containers:master Mar 8, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants