-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO TESTS NEEDED] podman-remote build does not support volumes #9651
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -86,7 +86,7 @@ resulting image's configuration. | |||
#### **--cache-from** | |||
|
|||
Images to utilize as potential cache sources. Podman does not currently support | |||
caching so this is a NOOP. | |||
caching so this is a NOOP. (Not available for remote commands) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest "This option is not available with the remote Podman client"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have this comment all over the podman-run and podman-create man page, so I will make the change everywhere. Want to get @TomSweeneyRedHat agreement though so we don't bikeshed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mheon's suggestion SGTM
14b9453
to
37dd5cf
Compare
Remove --volume option from podman-remote since it is not supported, also add information to podman-build man page indicating options not supported over remote connections. Signed-off-by: Daniel J Walsh <[email protected]>
LGTM |
Hmm, I could have sworn I LGTM'd this earlier, I'll do so now. |
/lgtm |
Remove --volume option from podman-remote since it is
not supported, also add information to podman-build man page
indicating options not supported over remote connections.
Signed-off-by: Daniel J Walsh [email protected]