Numerous buildah fixes found by Ed's testing of buildah tests against podman. #9592
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
cmd/podman/images/build.go
Outdated
| @@ -1,7 +1,9 @@ | |||
| package images | |||
|
|
|||
| import ( | |||
| "fmt" | |||
There was a problem hiding this comment.
Looks like you need to drop this
rhatdan
force-pushed
the
timestamp
branch
2 times, most recently
from
7b3b853 to
ca4fdea
Compare
test/system/070-build.bats
Outdated
| # Build an image. For .dockerignore | ||
| local -a ignoreflag | ||
| if [[ $ignorefile != ".dockerignore" ]]; then | ||
| ignoreflag="--ignorefile $ignorefile" |
There was a problem hiding this comment.
Oops. I guess this has to be --ignorefile $tmpdir/$ignorefile. (Sorry, for obvious reasons I was unable to test this yesterday. I had assumed that podman/buildah would treat paths as relative to the context directory; and TBH I kind of am surprised that it doesn't. So maybe this is a code bug. Anyhow, here's the reason).
rhatdan
force-pushed
the
timestamp
branch
4 times, most recently
from
5afe78f to
91e4141
Compare
|
The testing needs more help.... |
|
Looks like dns-search isn't actually working? |
Fixes: containers#9570 Signed-off-by: Daniel J Walsh <[email protected]>
Fixes: containers#9571 Signed-off-by: Daniel J Walsh <[email protected]>
Fixes: containers#9574 Signed-off-by: Daniel J Walsh <[email protected]>
Signed-off-by: Daniel J Walsh <[email protected]>
|
LGTM! |
github-actions
bot
added
the
locked - please file new issue/PR
Add support for podman build --ignorefile
podman build --build-arg should fall back to environment
Handle podman build --dns-search
Fix podman build --pull-never