-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utils: takes the longest path on cgroup v1 #9302
utils: takes the longest path on cgroup v1 #9302
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6824e36
to
4518a4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @giuseppe
This will fix https://bugzilla.redhat.com/show_bug.cgi?id=1726442
5650a1c
to
36f6bb4
Compare
CI is not yet happy:
|
36f6bb4
to
23e2238
Compare
/lgtm |
23e2238
to
5b0e383
Compare
5b0e383
to
efcecc4
Compare
Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
2b9e028
to
a7220b4
Compare
/lgtm |
a7220b4
to
77c63a7
Compare
77c63a7
to
6a04fa8
Compare
now getCgroupProcess takes the longest path on cgroup v1, instead of complaining if the paths are different. This should help when --cgroups=split is used on cgroup v1 and the process cgroups look like: $ cat /proc/self/cgroup 11:pids:/user.slice/user-0.slice/session-4.scope 10:blkio:/ 9:cpuset:/ 8:devices:/user.slice 7:freezer:/ 6:memory:/user.slice/user-0.slice/session-4.scope 5:net_cls,net_prio:/ 4:hugetlb:/ 3:cpu,cpuacct:/ 2:perf_event:/ Signed-off-by: Giuseppe Scrivano <[email protected]>
6a04fa8
to
660a06f
Compare
LGTM |
Ugh, thought this had been merged and backported into v3.0... This solves an 8.4 potential blocker BZ.... |
/hold cancel |
/lgtm |
backport to 3.0: #9332 |
@giuseppe the tests "podman run with cgroups=split" is failed for downstream podman on RHEL 8.4. 1:name=systemd:/user.slice/user-0.slice/session-11.scope/supervisor
|
ignore named hierarchies for the --cgroups=split test as crun does not set it. Closes: containers#9302 (comment) Signed-off-by: Giuseppe Scrivano <[email protected]>
@chuanchang, could you open bugzilla against RHEL 8.4? We need that for backports now. |
now getCgroupProcess takes the longest path on cgroup v1, instead of
complaining if the paths are different.
This should help when --cgroups=split is used on cgroup v1 and the
process cgroups look like:
$ cat /proc/self/cgroup
11:pids:/user.slice/user-0.slice/session-4.scope
10:blkio:/
9:cpuset:/
8:devices:/user.slice
7:freezer:/
6:memory:/user.slice/user-0.slice/session-4.scope
5:net_cls,net_prio:/
4:hugetlb:/
3:cpu,cpuacct:/
2:perf_event:/
Signed-off-by: Giuseppe Scrivano [email protected]