Cirrus: Collect ginkgo node logs artifacts

[cevich]

In rare cases, it's possible for one of the ginkgo processes to "hang".
When this occurs, the main output will contain this message:

Ginkgo timed out waiting for all parallel nodes to report

The only way to debug this was to look through concatenated printing
of the ginkgo node logs. This is a tedious and daunting task,
requiring special search knowledge, facing a "wall of text".

Simplify the situation by collecting the node logs separately, as
individual files in a cirrus-artifact. In this way, it's faster to
figure out which test "hung" by examining each log individually. The
log file which does not have a pass/fail summary at the end,
indicates the last test hung (for whatever reason), and includes it's
output (if any).

Signed-off-by: Chris Evich [email protected]

[cevich]

Ref. example ginkgo_node_logs item now listed under artifacts in integration testing tasks.

[rhatdan]

LGTM

[cevich]

@edsantiago PTAL...should be easy one.

[edsantiago]

Unfortunate that Cirrus does not offer an option to flatten the directory structure.

Do you know why logs weren't collected for any of the remote jobs? Should they have been?

[edsantiago]

I will assume that ginkgo logs don't exist for remoteintegration: https://cirrus-ci.com/task/5075101865476096?command=ginkgo_node_logs#L1

cat: '/var/tmp/go/src/github.com/containers/podman/test/e2e/ginkgo-node-*.log': No such file or directory

/lgtm
/hold

[cevich]

Unfortunate that Cirrus does not offer an option to flatten the directory structure.

No the only option is to move the around relative to $CIRRUS_WORKING_DIR 😞

I will assume that ginkgo logs don't exist for remoteintegration

Interesting...I believe it's because there is no -debug flag used for that target's command-line. I can add that in a separate PR if you think it's important.

[edsantiago]

Already done, #9200

[cevich]

Oh! Correction: This is because ginkgo-remote does not use multiple threads (nodes) for testing. So the log file would be 100% identical to what you see for the regular output.

[cevich]

Rebased w/ Ed's fix.

[edsantiago]

Confirmed: remote ginkgo logs now stored as artifacts

[edsantiago]

/lgtm
/hold

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [edsantiago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

/hold cancel