Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--tls-verify and --authfile should work for all remote commands #8042

Merged
merged 1 commit into from
Oct 20, 2020
Merged

--tls-verify and --authfile should work for all remote commands #8042

merged 1 commit into from
Oct 20, 2020

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Oct 16, 2020

These options are now fully supported in the remote API and should no
longer be hidden and/or documented as non supported.

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2020
@rhatdan rhatdan mentioned this pull request Oct 16, 2020
Merged
TomSweeneyRedHat
TomSweeneyRedHat reviewed Oct 16, 2020
View reviewed changes
test/e2e/search_test.go
@@ -278,7 +281,6 @@ registries = ['{{.Host}}:{{.Port}}']`
})

It("podman search doesn't attempt HTTP if force secure is true", func() {
SkipIfRemote("--tls-verify is not supported on podman-remote search")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edsantiago I just want to restate what a brilliant change adding this kind of text to the SkipIfRemote function is proving to be. TYVM once again.

TomSweeneyRedHat
TomSweeneyRedHat reviewed Oct 16, 2020
View reviewed changes
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
once the redness is cleared from the tests.

@rhatdan rhatdan force-pushed the tlsverify branch 2 times, most recently from ea73c7d to 1ae6cd1 Compare October 18, 2020 10:06
@rhatdan
--tls-verify and --authfile should work for all remote commands
3d2ad0f 
These options are now fully supported in the remote API and should no
longer be hidden and/or documented as non supported.

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan
Copy link
Member Author

rhatdan commented Oct 19, 2020

Some of these tests are still broken, but when I test by hand it seems to work fine. I don't have time to fix figure out what is going on here, but would like to get this merged to actually fix the handling of the --tls-verify and --authfile flags.

I will open an issue and have @QiWang19 Work on fixing the three tests.

@QiWang19
Copy link
Contributor

QiWang19 commented Oct 19, 2020 •
edited
Loading

one of the error is the test flake. #7139. I set up a PR applied this commit changes based on the master branch but failed to reproduce that unlinkat error.

@jwhonce
Copy link
Member

jwhonce commented Oct 20, 2020

LGTM

tests appear to be timing out on podman info

[+0008s] not ok 53 [01-basic] Time for ten /info requests
[+0008s] #  expected: <= 7 seconds
[+0008s] #    actual: 8 seconds

@QiWang19
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2020
@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 4822cc8 into containers:master Oct 20, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

Assignees

@QiWang19 QiWang19

@TomSweeneyRedHat TomSweeneyRedHat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rhatdan @openshift-ci-robot @QiWang19 @jwhonce @TomSweeneyRedHat @openshift-merge-robot