Add support for slirp network for pods #7783
Conversation
|
|
||
| It("podman create pod with slirp network option", func() { | ||
| name := "test" | ||
| session := podmanTest.Podman([]string{"pod", "create", "--name", name, "--network", "slirp4netns:port_handler=slirp4netns", "-p", "8082:8000"}) |
There was a problem hiding this comment.
Can you add the network options to podman pod inspect and alter the test to verify that port_handler was set using that?
There was a problem hiding this comment.
Should this be under InfraConfig or another (new?) field?
|
Darn, failing tests. Time to dive back in. |
ashley-cui
force-pushed
the
slirp
branch
3 times, most recently
from
9bf8106
to
88dec59
Compare
pkg/specgen/pod_validate.go
Outdated
| @@ -72,9 +72,9 @@ func (p *PodSpecGenerator) Validate() error { | |||
| return exclusivePodOptions("NoInfra", "NoManageResolvConf") | |||
| } | |||
| } | |||
| if p.NetNS.NSMode != "" && p.NetNS.NSMode != Bridge && p.NetNS.NSMode != Default { | |||
| if p.NetNS.NSMode != "" && p.NetNS.NSMode != Bridge && p.NetNS.NSMode != Default && p.NetNS.NSMode != Slirp { | |||
There was a problem hiding this comment.
nit of a nit, I'd flop the last two tests around, just a bit more readable me thinks.
| if p.NetNS.NSMode != "" && p.NetNS.NSMode != Bridge && p.NetNS.NSMode != Default && p.NetNS.NSMode != Slirp { | |
| if p.NetNS.NSMode != "" && p.NetNS.NSMode != Bridge && p.NetNS.NSMode != Slirp && p.NetNS.NSMode != Default { |
|
couple of small nits, nice work and otherwise LGTM |
|
|
||
| Examples: | ||
| - `--network slirp4netns:outbound_addr=127.0.0.1,allow_host_loopback=true` | ||
| - `--networkslirp4netns:cidr=192.168.0.0/24` |
There was a problem hiding this comment.
These are great, but could you work them into a sample command and move them down to the "Examples" section near the bottom of this page please?
flag --network=slirp4netns[options] for root and rootless pods Signed-off-by: Ashley Cui <[email protected]>
|
@containers/podman-maintainers PTAL |
|
|
||
| $ podman pod create --network slirp4netns:outbound_addr=127.0.0.1,allow_host_loopback=true | ||
|
|
||
| $ podman pod create --network slirp4netns:cidr=192.168.0.0/24 |
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
flag --network=slirp4netns[options] for root and rootless pods
Fixes: #6097
Signed-off-by: Ashley Cui [email protected]