Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add APIV2 service files #5567

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Add APIV2 service files #5567

merged 1 commit into from
Mar 23, 2020

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Mar 20, 2020

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2020
@rhatdan
Copy link
Member Author

rhatdan commented Mar 20, 2020

Fixes: #5563

giuseppe
giuseppe reviewed Mar 20, 2020
View reviewed changes
Makefile
install ${SELINUXOPT} -m 644 contrib/systemd/user/podman.socket ${DESTDIR}${USERSYSTEMDDIR}/podman.socket
install ${SELINUXOPT} -m 644 contrib/systemd/user/podman.service ${DESTDIR}${USERSYSTEMDDIR}/podman.service
install ${SELINUXOPT} -m 644 contrib/systemd/system/podman.socket ${DESTDIR}${SYSTEMDDIR}/podman.socket
install ${SELINUXOPT} -m 644 contrib/systemd/system/podman.service ${DESTDIR}${SYSTEMDDIR}/podman.service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should make uninstall remove them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@rhatdan
Add APIV2 service files
8ab686f 
Also fix issue in pods_test.go

Signed-off-by: Daniel J Walsh <[email protected]>
@TomSweeneyRedHat
Copy link
Member

LGTM assuming happy tests

@mheon
Copy link
Member

mheon commented Mar 20, 2020

Does @lsm5 need to make changes to the Fedora specfiles to install these?

@rhatdan
Copy link
Member Author

rhatdan commented Mar 20, 2020

He will once it merges, Just for Rawhide, I fixed F32 and F31.

@rhatdan
Copy link
Member Author

rhatdan commented Mar 20, 2020

Once this merges I will fix the rawhide spec file.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member Author

rhatdan commented Mar 21, 2020

@baude @giuseppe @TomSweeneyRedHat @mheon @saschagrunert Can someone give this the /lgtm it needs

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2020
@rhatdan
Copy link
Member Author

rhatdan commented Mar 22, 2020

@TomSweeneyRedHat @mheon @baude @vrothberg @giuseppe @QiWang19 @jwhonce This one got the "/lgtm" but did not merge. Could someone try again.
/retry

@openshift-merge-robot openshift-merge-robot merged commit 72a2011 into containers:master Mar 23, 2020
@marusak marusak mentioned this pull request Mar 23, 2020
Closed
@lsm5
Copy link
Member

lsm5 commented Mar 23, 2020

added to rawhide as well

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe giuseppe left review comments

@jwhonce jwhonce jwhonce approved these changes

@baude baude Awaiting requested review from baude

Assignees

@TomSweeneyRedHat TomSweeneyRedHat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rhatdan @TomSweeneyRedHat @mheon @openshift-ci-robot @lsm5 @giuseppe @jwhonce @openshift-merge-robot