Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

honor pull policy in play kube #4993

Merged
merged 1 commit into from
Jan 28, 2020
Merged

honor pull policy in play kube #4993

merged 1 commit into from
Jan 28, 2020

Conversation

baude
Copy link
Member

@baude baude commented Jan 27, 2020

When a container specification has a pull policy, we should honor it when recreating the pods/containers from yaml.

Fixes: #4880

Signed-off-by: Brent Baude [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S labels Jan 27, 2020
@jwhonce
Copy link
Member

jwhonce commented Jan 27, 2020

LGTM

@haircommander
Copy link
Collaborator

LGTM besides possibly more test coverage 😄

@haircommander
Copy link
Collaborator

also given this comment #4880 (comment) I'd either like special case handling for latest or a new issue to track that we don't currently handle latest similarly

@baude
Copy link
Member Author

baude commented Jan 28, 2020

also given this comment #4880 (comment) I'd either like special case handling for latest or a new issue to track that we don't currently handle latest similarly

did this per our discussion too!

haircommander
haircommander reviewed Jan 28, 2020
View reviewed changes
pkg/adapter/pods.go Outdated Show resolved Hide resolved
@haircommander
Copy link
Collaborator

one blocking nit, one non-blocking nit, otherwise LGTM 🥂

@baude
honor pull policy in play kube
31a1f44 
When a container specification has a pull policy, we should honor it when recreating the pods/containers from yaml.  furthermore, ini kube, if a tag is :latest, then the always pull policy is automatically instituted.

Fixes: containers#4880

Signed-off-by: Brent Baude <[email protected]>
@haircommander
Copy link
Collaborator

comments addressed in record time, LGTM

@haircommander
Copy link
Collaborator

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jan 28, 2020
@baude
Copy link
Member Author

baude commented Jan 28, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit 63b1656 into containers:master Jan 28, 2020
@baude baude deleted the playkubepull branch May 7, 2020 13:12
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@haircommander haircommander haircommander left review comments

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman play kube does not pull images like it should
6 participants
@baude @openshift-ci-robot @jwhonce @haircommander @TomSweeneyRedHat @openshift-merge-robot