Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processes execed into container should match container label #4372

Merged
merged 1 commit into from
Oct 30, 2019

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Oct 29, 2019

Processes execed into a container were not being run with the correct label.

Signed-off-by: Daniel J Walsh [email protected]

Processes execed into a container were not being run with the correct label.

Signed-off-by: Daniel J Walsh <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S labels Oct 29, 2019
@mheon
Copy link
Member

mheon commented Oct 29, 2019 via email

@giuseppe
Copy link
Member

LGTM

@rhatdan
Copy link
Member Author

rhatdan commented Oct 29, 2019

Fixes: #4361

@TomSweeneyRedHat
Copy link
Member

LGTM assuming happy tests.
One of the tests in common failed, I've restarted it in case it's a flake but I'm not sure about that.

@haircommander
Copy link
Collaborator

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2019
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 2e8eb84 into containers:master Oct 30, 2019
session.WaitWithDefaultTimeout()
session1 := podmanTest.Podman([]string{"exec", "test1", "cat", "/proc/self/attr/current"})
session1.WaitWithDefaultTimeout()
Expect(session.OutputToString()).To(Equal(session1.OutputToString()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand this test; I get the same results with 1.6.2-2.fc30 (i.e. two consecutive execs have the same context). Just mentioning it as an FYI.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops typo. First one is supposed to be /proc/1/attr/current, Will open a PR to fix.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants