-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Processes execed into container should match container label #4372
Conversation
Processes execed into a container were not being run with the correct label. Signed-off-by: Daniel J Walsh <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM once things go green
…On Tue, Oct 29, 2019, 16:06 OpenShift CI Robot ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *APPROVED*
This pull-request has been approved by: *rhatdan
<#4372
The full list of commands accepted by this bot can be found here
<https://go.k8s.io/bot-commands?repo=containers%2Flibpod>.
The pull request process is described here
<https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>
Needs approval from an approver in each of these files:
- OWNERS <https://github.com/containers/libpod/blob/master/OWNERS>
[rhatdan]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4372>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3AOCA7SGHVYW5FJQIKNHLQRCJTPANCNFSM4JGOXWJQ>
.
|
LGTM |
Fixes: #4361 |
LGTM assuming happy tests. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
session.WaitWithDefaultTimeout() | ||
session1 := podmanTest.Podman([]string{"exec", "test1", "cat", "/proc/self/attr/current"}) | ||
session1.WaitWithDefaultTimeout() | ||
Expect(session.OutputToString()).To(Equal(session1.OutputToString())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand this test; I get the same results with 1.6.2-2.fc30 (i.e. two consecutive exec
s have the same context). Just mentioning it as an FYI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops typo. First one is supposed to be /proc/1/attr/current, Will open a PR to fix.
Processes execed into a container were not being run with the correct label.
Signed-off-by: Daniel J Walsh [email protected]