Test that PTYs created by 'podman exec --tty' have non-zero size

[debarshiray]

Signed-off-by: Debarshi Ray [email protected]

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: debarshiray
To complete the pull request process, please assign baude
You can assign the PR to them by writing /assign @baude in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

Hi @debarshiray. Thanks for your PR.

I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[debarshiray]

This is an attempted test for #3903

[TomSweeneyRedHat]

/ok-to-test

[rhatdan]

@debarshiray looks like your tests is failing for rootless.

[mheon]

[+0766s]   Expected
[+0766s]       <bool>: true
[+0766s]   to be false
[+0766s] 
[+0766s]   /var/tmp/go/src/github.com/containers/libpod/test/e2e/exec_test.go:138

[mheon]

Hmmm. We're forwarding TTY size over from the parent process, right?

Is it possible the parent (Ginkgo) doesn't have a non-zero PTY size?

[debarshiray]

Hmmm. We're forwarding TTY size over from the parent process, right?

Is it possible the parent (Ginkgo) doesn't have a non-zero PTY size?

I see that it's querying the outer terminal size using TIOCGWINSZ in GetWinsize in github.com/docker/docker/pkg/term. So, I guess this shows that the outer terminal doesn't have a non-zero size.

Is there even an outer terminal device provided by Ginkgo? I don't know. I will try poking around at Ginkgo to see if I can figure anything out.

[github-actions]

This pull request had no activity for 30 days. In the absence of activity or the "do-not-close" label, the pull request will be automatically closed within 7 days.