Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirrus: Minor: Simplify crun test task #3822

Merged
merged 1 commit into from
Aug 17, 2019

Conversation

cevich
Copy link
Member

@cevich cevich commented Aug 15, 2019

Signed-off-by: Chris Evich [email protected]

@mheon
Copy link
Member

mheon commented Aug 15, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2019
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming happy tests

@cevich cevich force-pushed the simplify_crun_task branch from 02a2d2c to 2dc76a9 Compare August 16, 2019 18:31
@cevich cevich force-pushed the simplify_crun_task branch from 2dc76a9 to 7e406fe Compare August 16, 2019 18:33
@cevich
Copy link
Member Author

cevich commented Aug 16, 2019

@giuseppe PTAL

@giuseppe
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2019
@openshift-merge-robot openshift-merge-robot merged commit 098ce2f into containers:master Aug 17, 2019
@cevich cevich deleted the simplify_crun_task branch June 30, 2021 18:04
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants