pkg/cgroups: use DBUS session when rootless #3810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
/cc @vrothberg |
giuseppe
force-pushed
the
use-cgroups
branch
4 times, most recently
from
2e611ba to
ac3016f
Compare
|
LGTM assuming happy tests |
mheon
reviewed
Aug 14, 2019
pkg/cgroups/systemd.go
Outdated
| @@ -72,18 +66,30 @@ func systemdCreate(path string) error { | |||
| See the License for the specific language governing permissions and | |||
| limitations under the License. | |||
| */ | |||
| /* | |||
| systemdDestroyConn is copied from containerd/cgroups/systemd.go file, that | |||
There was a problem hiding this comment.
Did we dupe the license comment here?
use the DBUS user session when running in rootless mode. Closes: containers#3801 Signed-off-by: Giuseppe Scrivano <[email protected]>
|
Code LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the DBUS user session when running in rootless mode.
Closes: #3801
Signed-off-by: Giuseppe Scrivano [email protected]