tests for exit status on podman run --rm

[edsantiago]

...and on a container killed by 'podman rm -f'. See #3795

Signed-off-by: Ed Santiago [email protected]

[edsantiago]

I've confirmed that these tests fail when run against podman < d3a4331

[rhatdan]

Nice clever work on this.
LGTM

[mheon]

Should get matching tests into integration testing

…

On Tue, Aug 13, 2019, 13:23 Daniel J Walsh ***@***.***> wrote: Nice clever work on this. LGTM — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3804>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB3AOCHATJA7UEFIGLDT3XLQELUX5ANCNFSM4ILMVNJA> .

[mheon]

New tests here LGTM though

…

On Tue, Aug 13, 2019, 14:08 Matthew Heon ***@***.***> wrote: Should get matching tests into integration testing On Tue, Aug 13, 2019, 13:23 Daniel J Walsh ***@***.***> wrote: > Nice clever work on this. > LGTM > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#3804>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AB3AOCHATJA7UEFIGLDT3XLQELUX5ANCNFSM4ILMVNJA> > . >

[rhatdan]

Just need to get them to pass... :^)

[edsantiago]

OOF! I thought I had tested podman-remote; turns out I fat-fingered my test.

Looks like we have the same broken-exit-status issue with podman-remote. Should I reopen #3795 or open a new one?

[mheon]

Prooobably a separate issue... I'd open a new issue for it

[mheon]

Actually - did --rm exit codes with remote ever work?

I sort of suspect the answer is "no"

[haircommander]

@mheon I know that I had to wire a bunch of stuff together to get exec exit codes. I'd believe --rm exit codes were never implemented.

[edsantiago]

Actually - did --rm exit codes with remote ever work?

test/system/030-run.bats has worked fine with podman-remote since the day I wrote it. So, yes, I am expecting exit codes to work. I'll open a new issue.

[mheon]

@edsantiago I meant specifically exit codes with podman run --rm or containers force-removed while running

[mheon]

(Because I'm fairly certain our mitigation for missing exit codes only ever worked locally - the files never existed on the remote system)

[edsantiago]

I meant specifically exit codes with podman run --rm or containers force-removed while running

Since we've never had tests, and I've never had a working podman-remote on RHEL8 to run docker-autotest on, I don't know. I still kind of think it might be a good idea to have them, but I can skip_if_remote the new tests in this PR if it is too difficult.

[mheon]

Ummm.
@baude We have remote events, right? We can probably hack up something similar to what we're doing here by calling that varlink endpoint

[edsantiago]

/retest

[edsantiago]

Rebased, and disabled the new tests in podman-remote mode. Will enable if/when #3808 gets fixed.

Tests finally green after hours of clicking Re-run on flakes.

[mheon]

We need to talk about flakes sometime... If I remember, I'll bring it up tomorrow at scrum.

[mheon]

/approve
Tests LGTM

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

/lgtm