Add Capability support to play kube #3692
Conversation
capabilities that were added and dropped were several times duplicated. Fix this Signed-off-by: Peter Hunt <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
I think your third commit might need to be squashed 😄 |
|
|
||
| } | ||
| if caps := containerYAML.SecurityContext.Capabilities; caps != nil { | ||
| for _, capability := range caps.Add { |
There was a problem hiding this comment.
I think lint is going to want this changed to containerConfig.CapAdd = append(containerConfig.CapAdd, caps.Add...)
There was a problem hiding this comment.
they shouldn't be compatible types though
There was a problem hiding this comment.
Ahhh, yeah the conversion should break that one.
haircommander
force-pushed
the
play-caps
branch
from
9699683 to
16670d3
Compare
curse my hasty pushing! |
Take capabilities written in a kube and add to a container adapt test suite and write cap-add/drop tests Signed-off-by: Peter Hunt <[email protected]>
haircommander
force-pushed
the
play-caps
branch
from
16670d3 to
834107c
Compare
|
LGTM once tests go green |
|
4th times the charm? |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
as well as fix a generate bug where the capabilites were duplicated
fixes #3689