Set -env variables as appropriate #3665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
openshift-ci-robot
added
the
approved
mheon
reviewed
Jul 29, 2019
QiWang19
changed the title
giuseppe
requested changes
Jul 30, 2019
QiWang19
force-pushed
the
env
branch
2 times, most recently
from
8fa7103 to
a4570f0
Compare
docs/podman-create.1.md
Outdated
| @@ -253,7 +253,7 @@ You need to specify multi option commands in the form of a json string. | |||
|
|
|||
| Set environment variables | |||
|
|
|||
| This option allows you to specify arbitrary environment variables that are available for the process that will be launched inside of the container. If you specify a environment variable without a value, podman will check the host environment for a value or set the environment to "". If you specify a environment variable ending in --*--, podman will search the host environment for variables starting with the prefix and add them to the container. If you want to add an environment variable with a ***** following it, then you need to set a value. | |||
| This option allows arbitrary environment variables that are available for the process to be launched inside of the container. If an environment variable is specified without a value, Podman will check the host environment for a value and set the variable only if it is set on the host. If an environment variable ending in __*__ is specified, Podman will search the host environment for variables starting with the prefix and will add those variable to the container. If an environment variable with a trailing ***** is specified, then a value must be supplied. | |||
|
|
|||
| See **Environment** note below for precedence. | |||
There was a problem hiding this comment.
Can you add a link to #environment? from the **Environment**
|
@QiWang19 fwiw, I'm done picking nits! |
QiWang19
force-pushed
the
env
branch
2 times, most recently
from
081da34 to
bf22f16
Compare
close containers#3648 podman create and podman run do not set --env variable if the environment is not present with a value Signed-off-by: Qi Wang <[email protected]>
|
@TomSweeneyRedHat @mheon PTAL |
|
@giuseppe has you change been addressed? Can you remove the request if so please? |
giuseppe
approved these changes
Jul 30, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mheon, QiWang19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3648
podman create and podman run do not set --env value if the environment is not present with a value
Signed-off-by: Qi Wang [email protected]