support podman ps filter regular expressions #3599
Conversation
podman ps --filter use regexp to match the container name. Signed-off-by: Qi Wang <[email protected]>
|
/approve Thanks for the speedy response here |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon, QiWang19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
I wonder if we need more than this - we might need to use regexp matching for all filters? Should test against Docker to determine. |
|
I think no other filters need regular expression after looking through the filters that in common with docker. |
| Expect(session.ExitCode()).To(Equal(0)) | ||
| fullCid := session.OutputToString() | ||
|
|
||
| session2 := podmanTest.Podman([]string{"run", "-d", "--name", "test11", ALPINE, "top"}) |
There was a problem hiding this comment.
This looks like it should fail, I think this should be named test2.
There was a problem hiding this comment.
Never mind, I guess it is test11.
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Close #3394
bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1731107
podman ps --filter use regexp to match the container name.
Signed-off-by: Qi Wang [email protected]