podman: add --ulimit host #3491
Conversation
openshift-ci-robot
added
approved
pkg/spec/spec.go
Outdated
| return errors.New("ulimit can use host only once") | ||
| } | ||
|
|
||
| type Rlimit struct { |
There was a problem hiding this comment.
Does this need to be public? It's purely scoped within this loop
There was a problem hiding this comment.
good point. I've pushed a new version
|
One nit otherwise LGTM |
giuseppe
force-pushed
the
rlimit-host
branch
5 times, most recently
from
6062cd1 to
0bd184d
Compare
|
LGTM |
giuseppe
force-pushed
the
rlimit-host
branch
9 times, most recently
from
7f23de3 to
0f99d88
Compare
add a simple way to copy ulimit values from the host. if --ulimit host is used then the current ulimits in place are copied to the container. Signed-off-by: Giuseppe Scrivano <[email protected]>
|
tests are passing |
|
ping |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, jamescassell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
| @@ -553,6 +559,20 @@ func addRlimits(config *CreateConfig, g *generate.Generator) error { | |||
| ) | |||
|
|
|||
| for _, u := range config.Resources.Ulimit { | |||
| if u == "host" { | |||
There was a problem hiding this comment.
Is there really no way to tell runc "just don't change rlimits"?
There was a problem hiding this comment.
it seems I've unnecessarily complicated things. Looks like it is enough to not specify any limits block and that won't change the rlimits. I'll do some more tests and open a PR
There was a problem hiding this comment.
much simpler version: #3583
github-actions
bot
added
the
locked - please file new issue/PR
add a simple way to copy ulimit values from the host.
if --ulimit host is used then the current ulimits in place are copied
to the container.
Signed-off-by: Giuseppe Scrivano [email protected]