Output name of process on runlabel command #3158
Conversation
openshift-ci-robot
added
size/XS
needs-ok-to-test
|
Hi @kofalt. Thanks for your PR. I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Can one of the admins verify this patch?
|
cmd/podman/runlabel.go
Outdated
| @@ -152,7 +152,7 @@ func runlabelCmd(c *cliconfig.RunlabelValues) error { | |||
| return err | |||
| } | |||
| if !c.Quiet { | |||
| fmt.Printf("command: %s\n", strings.Join(cmd, " ")) | |||
| fmt.Printf("command: %s\n", strings.Join(append(os.Args[0], cmd[1:]), " ")) | |||
There was a problem hiding this comment.
Tests are complaining that the first argument to append must be a slice, so I think you'll need to make it append([]string{os.Args[0]}, cmd[1:]...)
There was a problem hiding this comment.
Guilty as charged, dry-coded :)
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
and removed
needs-ok-to-test
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kofalt, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
kofalt
force-pushed
the
runlabel-formating
branch
from
76e249d to
f1d75ff
Compare
Signed-off-by: Nathaniel Kofalt <[email protected]>
kofalt
force-pushed
the
runlabel-formating
branch
from
f1d75ff to
f4a4c7c
Compare
|
/retest |
|
LGTM |
|
@vrothberg please review and merge if happy |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
From the logic in funcs.go, it looks like
/proc/self/exeis used to ensure no further indirection.However, this also shows up in the debug output:
This isn't as helpful since the command cannot be copy-pasted and reused.
This patch is a dead-simple swap-in for the current process name during the debug log.