Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable podman-remote on windows #3031

Merged
merged 1 commit into from
May 1, 2019
Merged

enable podman-remote on windows #3031

merged 1 commit into from
May 1, 2019

Conversation

baude
Copy link
Member

@baude baude commented Apr 27, 2019

build a podman-remote binary for windows that allows users to use the
remote client on windows and interact with podman on linux system.

Signed-off-by: baude [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 27, 2019
@rhatdan
Copy link
Member

rhatdan commented Apr 28, 2019

LGTM

@baude
Copy link
Member Author

baude commented Apr 28, 2019

@vrothberg what do i have to do to make the world happy here?

@mheon
Copy link
Member

mheon commented Apr 29, 2019

I really don't like moving code around for the vague goal of 'making it compile' with no further logic. We already have a bunch of _linux.go files hanging around from our last attempt to make that happen... Let's not pretend that this code is designed to run anywhere except a Linux system, even if it doesn't compile there. IMO, drop any code that needs a compile check in an _linux file, because however good our intentions are, we probably won't clean this up much in the future, and we already left a bit of a mess last time we tried this.

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #3016) made this pull request unmergeable. Please resolve the merge conflicts.

mheon
mheon reviewed Apr 30, 2019
View reviewed changes
pkg/util/utils_windows.go Outdated Show resolved Hide resolved
mheon
mheon reviewed Apr 30, 2019
View reviewed changes
pkg/adapter/sigproxy.go Outdated Show resolved Hide resolved
mheon
mheon reviewed Apr 30, 2019
View reviewed changes
utils/utils_supported.go
@@ -0,0 +1,39 @@
// +build linux darwin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop Darwin, make this utils_linux.go

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mheon i cannot do that one yet ... it dives deep into oci and runtime.go respectively. How about a TODO and gimmie a pass on this one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. I'll request a rename to utils_unix.go still, but I'm good to merge once that happens

@baude
enable podman-remote on windows
0b6bb6a 
build a podman-remote binary for windows that allows users to use the
remote client on windows and interact with podman on linux system.

Signed-off-by: baude <[email protected]>
@mheon
Copy link
Member

mheon commented May 1, 2019

I'm going to regret merging this before my stuff (merge conflicts are gonna hurt), but ah well
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2019
@baude
Copy link
Member Author

baude commented May 1, 2019

it's you or me! today it's you!

@openshift-merge-robot openshift-merge-robot merged commit ad68036 into containers:master May 1, 2019
@rh-atomic-bot rh-atomic-bot mentioned this pull request May 1, 2019
Merged
@seriousme seriousme mentioned this pull request May 17, 2019
Closed
@baude baude deleted the remotewindows branch December 22, 2019 19:08
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mheon mheon mheon left review comments

@rhatdan rhatdan rhatdan left review comments

@giuseppe giuseppe Awaiting requested review from giuseppe

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@baude @openshift-ci-robot @rhatdan @mheon @rh-atomic-bot @openshift-merge-robot