BATS: new tests, and improvements to existing ones #2703
Conversation
New: - podman exec - podman load (requires containers#2674) - CLI parsing (regression test for containers#2574) Improved: - help: test "podman NoSuchCommand", and subcommands - help: test "podman cmd" without required args - pod: start with --infra=false; this allows running rootless - log: also run 'logs' after container is run - log: test -f with two containers Also, use helpful descriptions for skip_if_rootless Tested on f29, root and rootless. As soon as podman-remote supports rm, I'll start testing that too. Signed-off-by: Ed Santiago <[email protected]>
There was a problem hiding this comment.
Just a gentle reminder/suggestion: I feel we're near the time to avoid testing individual commands and focus on workflows. I understand some duplication vs the e2e tests is unavoidable. If there are bugs you're finding in system-tests, they should result in new e2e tests being written. Ask for help and/or open issues for new e2e or unit-tests, the team can help write or fix them. My motivation is in the large: getting feedback to engineers as quickly, directly, and as near to the (guilty) change as possible 😁
LGTM
These are great. Very readable, and well thought out. Thanks for taking the initiative to write these and oversee assembly of the system-tests (including bug follow-through). I know first-hand the bug-part is no small feat, sometimes it seems like 90% of the work in writing a new test!
|
@rhatdan PTAL I'd ask Brent, but suspect he's reached his 5-lines of bash-quota for the week 😄 |
|
/approve |
|
/lgtm |
|
@rhatdan needs an approver to approve it first :) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, edsantiago, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
New:
Improved:
Also, use helpful descriptions for skip_if_rootless
Tested on f29, root and rootless. As soon as podman-remote
supports rm, I'll start testing that too.
Signed-off-by: Ed Santiago [email protected]