Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test docs fixups #2592

Merged
merged 1 commit into from
Mar 8, 2019
Merged

test docs fixups #2592

merged 1 commit into from
Mar 8, 2019

Conversation

baude
Copy link
Member

@baude baude commented Mar 8, 2019

adding some clarification on testing based on tom's input.

Signed-off-by: baude [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M labels Mar 8, 2019
@baude
test docs fixups
8a3b457 
adding some clarification on testing based on tom's input.

Signed-off-by: baude <[email protected]>
@baude baude requested review from TomSweeneyRedHat and removed request for mrunalp and vrothberg March 8, 2019 20:30
TomSweeneyRedHat
TomSweeneyRedHat reviewed Mar 8, 2019
View reviewed changes
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baude THanks! These changes LGTM, the only question is does the section talking about Papr still hold? We don't use that to test anymore right? If so, it should be removed.

@rhatdan
Copy link
Member

rhatdan commented Mar 8, 2019

LGTM
@TomSweeneyRedHat At least in the part of the doc that I reviewed, it looks like PAPR was removed.

@baude
Copy link
Member Author

baude commented Mar 8, 2019

yeah i removed it

@TomSweeneyRedHat
Copy link
Member

You're right @rhatdan, musta missed that review (or forgot) when it flew by.
Straght up LGTM then.

@baude
Copy link
Member Author

baude commented Mar 8, 2019

@TomSweeneyRedHat pull the trigger on it then :)

@TomSweeneyRedHat
Copy link
Member

Fixes: #2189

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2019
@TomSweeneyRedHat
Copy link
Member

Done and I've added the issue to today's log, thx again @baude.

@TomSweeneyRedHat TomSweeneyRedHat mentioned this pull request Mar 8, 2019
Closed
@openshift-merge-robot openshift-merge-robot merged commit 9b21f14 into containers:master Mar 8, 2019
@baude baude deleted the testfixups branch December 22, 2019 19:13
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

Assignees

@TomSweeneyRedHat TomSweeneyRedHat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@baude @openshift-ci-robot @rhatdan @TomSweeneyRedHat @openshift-merge-robot