-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add flag --extract tar file in podman cp #2532
Conversation
docs/podman-cp.1.md
Outdated
|
||
**--extract** | ||
|
||
Extract the tar file into the destination directory. If the destination argument is not give, extract the tar file in root directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest:
"Extract the tar file into the destination directory. If the destination option is not provided, extract the tar file into the root directory."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, my bad, try
"Extract the tar file into the destination directory. If the destination directory is not provided, extract the tar file into the root directory."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to add 'extract' to bash completions.
LGTM once you address the comments from @TomSweeneyRedHat |
7cd8af5
to
eea3ec6
Compare
@giuseppe @TomSweeneyRedHat fixed 🙋♀️ |
/lgtm |
--extract | ||
" | ||
_complete_ "$boolean_options" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, didn't realize this was entirely missing....
LGTM |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon, QiWang19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bot, retest this please |
Signed-off-by: Qi Wang <[email protected]>
bot, retest this please |
bot, retest this please |
fix #2520
Use
--extract
to extract tar file in source argument to the destination directorySigned-off-by: Qi Wang [email protected]