Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-ci] Packit: remove epel and re-enable c9s #24682

Merged

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Nov 26, 2024

We're moving away from proper rhel testing on upstream because of the slower pace of RHEL. This has already been done on aardvark-dns and some others.

CentOS 9 Stream does move fast enough that we can re-enable it here.

Does this PR introduce a user-facing change?

None

We're moving away from proper rhel testing on upstream because of the
slower pace of RHEL. This has already been done on aardvark-dns and some
others.

CentOS 9 Stream does move fast enough that we can re-enable it here.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 26, 2024
@lsm5 lsm5 marked this pull request as ready for review November 26, 2024 09:54
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2024
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Cockpit tests failed for commit 415d762. @martinpitt, @jelly, @mvollmer please check.

@lsm5
Copy link
Member Author

lsm5 commented Nov 26, 2024

@martinpitt @jelly something's up with cockpit on rawhide, doesn't seem related to the PR though.

@mheon
Copy link
Member

mheon commented Nov 26, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ceee7cb into containers:main Nov 26, 2024
39 of 40 checks passed
@martinpitt
Copy link
Contributor

martinpitt commented Nov 26, 2024

@lsm5 indeed, it seems criu or crun broke today, see the error message in the screenshot

The criu log shows some details:

(00.043508) Error (criu/vdso.c:381): vdso: Unexpected rt vDSO area bounds
(00.043513) Error (criu/vdso.c:613): vdso: Failed to fill self vdso symtable
(00.043518) Error (criu/kerndat.c:1906): kerndat_vdso_fill_symtable failed when initializing kerndat.

criu 4.0-2 is already a month old, and crun 1.18.2-1 3 weeks. New kernel/toolchain?

I'll download a rawhide VM and investigate.

However, I wonder, don't you have any coverage of podman container checkpoint/restore in podman's own tests? This does break fairly often, e.g. #24230 or https://bugzilla.redhat.com/show_bug.cgi?id=2105220 or https://bugzilla.redhat.com/show_bug.cgi?id=1944964 or https://issues.redhat.com/browse/RHEL-58354

@martinpitt
Copy link
Contributor

I reported the criu/kernel regression to https://bugzilla.redhat.com/show_bug.cgi?id=2328985 and silenced it in our tests in cockpit-project/bots#7146 . From now on, this failure will be ignored, i.e. tests should go back to green.

@Luap99
Copy link
Member

Luap99 commented Nov 26, 2024

However, I wonder, don't you have any coverage of podman container checkpoint/restore in podman's own tests?

We have plenty of checkpoint tests but we do not update our CI images so often so we lack behind. And we really cannot do these dnf install/update in a PR as this just constantly breaks for all kind of reasons. And then #24230 came exactly from such image update PR that broke in our own tests so we very much catch them (at some point) but if they do not get fixed then there is nothing we can do about it. So we skip and move on.

I reported the criu/kernel regression to https://bugzilla.redhat.com/show_bug.cgi?id=2328985 and silenced it in our tests in cockpit-project/bots#7146 . From now on, this failure will be ignored, i.e. tests should go back to green.

Thanks

@martinpitt
Copy link
Contributor

@lsm5 ah, thanks! That's very sensible indeed, we do the same for cockpit (and then these "image refreshes" expose all the OS regressions). I keep forgetting that you don't run podman tests in tmt/testing farm. Anyway, I think all good now.

@lsm5 lsm5 deleted the main-packit-remove-epel-targets branch November 27, 2024 10:30
@lsm5
Copy link
Member Author

lsm5 commented Nov 29, 2024

/cherrypick v5.3

@openshift-cherrypick-robot
Copy link
Collaborator

@lsm5: new pull request created: #24710

In response to this:

/cherrypick v5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants