-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip-ci] Packit: remove epel and re-enable c9s #24682
[skip-ci] Packit: remove epel and re-enable c9s #24682
Conversation
We're moving away from proper rhel testing on upstream because of the slower pace of RHEL. This has already been done on aardvark-dns and some others. CentOS 9 Stream does move fast enough that we can re-enable it here. Signed-off-by: Lokesh Mandvekar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cockpit tests failed for commit 415d762. @martinpitt, @jelly, @mvollmer please check. |
@martinpitt @jelly something's up with cockpit on rawhide, doesn't seem related to the PR though. |
/lgtm |
ceee7cb
into
containers:main
@lsm5 indeed, it seems criu or crun broke today, see the error message in the screenshot The criu log shows some details:
criu 4.0-2 is already a month old, and crun 1.18.2-1 3 weeks. New kernel/toolchain? I'll download a rawhide VM and investigate. However, I wonder, don't you have any coverage of |
I reported the criu/kernel regression to https://bugzilla.redhat.com/show_bug.cgi?id=2328985 and silenced it in our tests in cockpit-project/bots#7146 . From now on, this failure will be ignored, i.e. tests should go back to green. |
We have plenty of checkpoint tests but we do not update our CI images so often so we lack behind. And we really cannot do these
Thanks |
@lsm5 ah, thanks! That's very sensible indeed, we do the same for cockpit (and then these "image refreshes" expose all the OS regressions). I keep forgetting that you don't run podman tests in tmt/testing farm. Anyway, I think all good now. |
/cherrypick v5.3 |
@lsm5: new pull request created: #24710 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
We're moving away from proper rhel testing on upstream because of the slower pace of RHEL. This has already been done on aardvark-dns and some others.
CentOS 9 Stream does move fast enough that we can re-enable it here.
Does this PR introduce a user-facing change?