Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent line ending in win-installer project #24459

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

arixmkii
Copy link
Contributor

@arixmkii arixmkii commented Nov 4, 2024

There are 2 files in this project, which are using CRLF instead of LF line endings. This fixes the inconsistency as it doesn't look intentional.

Does this PR introduce a user-facing change?

None

@baude
Copy link
Member

baude commented Nov 4, 2024

/approve
LGTM

Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arixmkii, baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@mheon
Copy link
Member

mheon commented Nov 4, 2024

Sure
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2da164c into containers:main Nov 4, 2024
37 of 38 checks passed
@arixmkii arixmkii deleted the contrib-le branch November 4, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants