podman: fix ro bind mounts if no* opts are on the source #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
giuseppe
force-pushed
the
fix-read-only-bind-mounts
branch
from
71966df to
427476f
Compare
|
LGTM: this resolves the issue on my f29 system. Thank you! |
giuseppe
force-pushed
the
fix-read-only-bind-mounts
branch
from
427476f to
bfde90a
Compare
|
/lgtm |
This is a workaround for the runc issue: opencontainers/runc#1247 If the source of a bind mount has any of nosuid, noexec or nodev, be sure to propagate them to the bind mount so that when runc tries to remount using MS_RDONLY, these options are also used. Closes: containers#2312 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
fix-read-only-bind-mounts
branch
from
bfde90a to
0f5ae3c
Compare
|
/lgtm |
|
Tested new changeset; works as expected. |
openshift-merge-robot
added a commit
that referenced
this pull request
Feb 25, 2019
podman: fix ro bind mounts if no* opts are on the source
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for the runc issue:
opencontainers/runc#1247
If the source of a bind mount has any of nosuid, noexec or nodev, be
sure to propagate them to the bind mount so that when runc tries to
remount using MS_RDONLY, these options are also used.
Closes: #2312
Signed-off-by: Giuseppe Scrivano [email protected]