CI: system tests: various small cleanups #24007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...of high system load (such as when running parallel tests). Allow time for services to reach desired state, by retrying a few times in a loop. Signed-off-by: Ed Santiago <[email protected]>
...not just when running parallel Bats, because Bats does not provide any way to know if we're parallel. Signed-off-by: Ed Santiago <[email protected]>
Only in 000-TEMPLATE. I know I need to write more thorough documentation. I choose to defer that. Signed-off-by: Ed Santiago <[email protected]>
The "rm on stopping containers" test is flaking under high load, probably because I bumped up two timeouts in the healthcheck container that it relies on. Bump up this test's timeout as well. Signed-off-by: Ed Santiago <[email protected]>
openshift-ci
bot
added
do-not-merge/release-note-label-needed
Luap99
approved these changes
Sep 19, 2024
Comment on lines
+980
to
+983
| # When running under heavy load (e.g. parallel tests), it | ||
| # may take a little while for service to reach Started | ||
| for tries in $(seq 1 5); do | ||
| run journalctl "--since=$STARTED_TIME" --unit="$QUADLET_SERVICE_NAME" |
There was a problem hiding this comment.
AFAIK systemctl should wait for it to reach started state, but we know journald is not updating fast enough even after you write to it successfully (i.e. all the races in podman logs with journald) so there sadly doesn't seem to be any way avoid these loops
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly to minimize flakes in parallel mode. And some documentation.