CI: e2e: workaround for events out-of-sequence flake #23979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note-none
approved
|
We were not able to find or create Copr project Unless the HTTP status code above is >= 500, please check your configuration for:
|
Luap99
reviewed
Sep 17, 2024
Comment on lines
+272
to
+273
| Expect(lines).To(ContainSubstring("network connect" + eventDetails)) | ||
| Expect(lines).To(ContainSubstring("network disconnect" + eventDetails)) |
There was a problem hiding this comment.
only the image events should be out of order so I think there is still a point in testing that connect is before disconnect.
podman-remote events are not flushed, so order is not guaranteed. This results in CI flakes. Only on Debian, for reasons unknown. Make the network-connection events test more lenient when remote. Closes: containers#23634 (but does not actually fix it) Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
workaround-remote-events-flake
branch
from
86d7d60
to
111a4bb
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit 214e64e
into
containers:main
55 of 56 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
podman-remote events are not flushed, so order is not guaranteed.
This results in CI flakes. Only on Debian, for reasons unknown.
Make the network-connection events test more lenient when remote.
Closes: #23634 (but does not actually fix it)
Signed-off-by: Ed Santiago [email protected]