-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: e2e: workaround for events out-of-sequence flake #23979
CI: e2e: workaround for events out-of-sequence flake #23979
Conversation
We were not able to find or create Copr project
Unless the HTTP status code above is >= 500, please check your configuration for:
|
Expect(lines).To(ContainSubstring("network connect" + eventDetails)) | ||
Expect(lines).To(ContainSubstring("network disconnect" + eventDetails)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only the image events should be out of order so I think there is still a point in testing that connect is before disconnect.
podman-remote events are not flushed, so order is not guaranteed. This results in CI flakes. Only on Debian, for reasons unknown. Make the network-connection events test more lenient when remote. Closes: containers#23634 (but does not actually fix it) Signed-off-by: Ed Santiago <[email protected]>
86d7d60
to
111a4bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
214e64e
into
containers:main
podman-remote events are not flushed, so order is not guaranteed.
This results in CI flakes. Only on Debian, for reasons unknown.
Make the network-connection events test more lenient when remote.
Closes: #23634 (but does not actually fix it)
Signed-off-by: Ed Santiago [email protected]