-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quadlet - Split getUnitDirs to small functions #23970
Quadlet - Split getUnitDirs to small functions #23970
Conversation
Adjust the unittest Signed-off-by: Ygal Blum <[email protected]>
We were not able to find or create Copr project
Unless the HTTP status code above is >= 500, please check your configuration for:
|
This function started to make my head spin when I wanted to add the support requested in #23755. |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan, ygalblum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Does this PR introduce a user-facing change?
No