-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some dependencies that required go 1.22 #23844
Conversation
Update to gomega v1.34.2 and ginkgo v2.20.2, now that we use go 1.22 we can update them. Signed-off-by: Paul Holzinger <[email protected]>
We use go 1.22 now so we can update this. Signed-off-by: Paul Holzinger <[email protected]>
Signed-off-by: Paul Holzinger <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Ooooh, new flake (restarted):
At a guess, it's because the hook script exits without reading stdin? How do hooks work, do they get something in stdin? Or is it just command-line args? |
8a516c7
into
containers:main
Yes the config.json is send on stdin. You may be spot on. |
Now that we need go 1.22 we can update them
Does this PR introduce a user-facing change?