Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some dependencies that required go 1.22 #23844

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Sep 3, 2024

Now that we need go 1.22 we can update them

Does this PR introduce a user-facing change?

None

Update to gomega v1.34.2 and ginkgo v2.20.2, now that we use go 1.22 we
can update them.

Signed-off-by: Paul Holzinger <[email protected]>
We use go 1.22 now so we can update this.

Signed-off-by: Paul Holzinger <[email protected]>
Copy link
Contributor

openshift-ci bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2024
@Luap99 Luap99 changed the title Update some dependecies that required go 1.22 Update some dependencies that required go 1.22 Sep 3, 2024
@Luap99 Luap99 added the No New Tests Allow PR to proceed without adding regression tests label Sep 3, 2024
@mtrmac
Copy link
Collaborator

mtrmac commented Sep 3, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2024
@edsantiago
Copy link
Member

Ooooh, new flake (restarted):

           # podman [options] --hooks-dir /tmp/CI_rVFX/podman-e2e-146349208/subtest-1524189527/hooks,withcomma run quay.io/libpod/alpine:latest ls
           Error: OCI runtime error: crun: error executing hook `/tmp/CI_rVFX/podman-e2e-146349208/subtest-1524189527/hooks,withcomma/checkhooks.sh` (exit code: -33)
           writing to pipe: Broken pipe

At a guess, it's because the hook script exits without reading stdin? How do hooks work, do they get something in stdin? Or is it just command-line args?

@openshift-merge-bot openshift-merge-bot bot merged commit 8a516c7 into containers:main Sep 3, 2024
87 of 88 checks passed
@Luap99 Luap99 deleted the update-deps branch September 3, 2024 19:02
@Luap99
Copy link
Member Author

Luap99 commented Sep 4, 2024

At a guess, it's because the hook script exits without reading stdin? How do hooks work, do they get something in stdin?

Yes the config.json is send on stdin. You may be spot on.

@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Dec 4, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. No New Tests Allow PR to proceed without adding regression tests release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants