Add key CgroupsMode in Quadlet container unit #23675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruihe774
force-pushed
the
fix-pod-cgroups
branch
3 times, most recently
from
fcfde14 to
2e91f75
Compare
rhatdan
reviewed
Aug 20, 2024
rhatdan
reviewed
Aug 20, 2024
|
Thanks @ruihe774 Could you split this PR into three separate MRs, merging the first two PRs into one and then we can review them separately. Overall they look good. |
ruihe774
force-pushed
the
fix-pod-cgroups
branch
from
2e91f75 to
4cf343c
Compare
ruihe774
changed the title
ruihe774
force-pushed
the
fix-pod-cgroups
branch
from
4cf343c to
1222b63
Compare
ygalblum
reviewed
Aug 20, 2024
Signed-off-by: Misaki Kasumi <[email protected]>
ruihe774
force-pushed
the
fix-pod-cgroups
branch
from
1222b63 to
1ccccde
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruihe774, ygalblum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
LGTM |
|
/lgtm |
openshift-merge-bot
bot
merged commit 8be89ca
into
containers:main
85 of 86 checks passed
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23664.
Does this PR introduce a user-facing change?