Do not segfault on hard stop #23666
Do not segfault on hard stop #23666
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@containers/podman-maintainers PTAL |
rhatdan
added
the
No New Tests
Podman machine on MAC can segfault on hard stop. Fixes: 23654 Signed-off-by: Daniel J Walsh <[email protected]>
|
Since lots of tests are failing, going back to ignoring error. |
|
LGTM |
| @@ -83,7 +83,9 @@ func (vf *Helper) stateChange(newState rest.StateChange) error { | |||
| } | |||
| payload := bytes.NewReader(b) | |||
| serverResponse, err := vf.post(vf.Endpoint+state, payload) | |||
| _ = serverResponse.Body.Close() | |||
| if err == nil { | |||
| _ = serverResponse.Body.Close() | |||
There was a problem hiding this comment.
do you need to check if serverResponse is nil and/or the Body?
There was a problem hiding this comment.
I don't think so, unless we have to check this everywhere. v.get() as well.
There was a problem hiding this comment.
if vf.post() returns an error then serverResponse is nil. I would think client.Do(req) will return the correct serverResponse or nil with an err.
There was a problem hiding this comment.
yeah checking the error alone should be fine
openshift-merge-bot
bot
merged commit 426aac3
into
containers:main
stale-locking-app
bot
added
the
locked - please file new issue/PR
Podman machine on MAC can segfault on hard stop.
Fixes: #23654
Does this PR introduce a user-facing change?