-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/e2e: on test failures dump server stack strace #23631
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We were not able to find or create Copr project
Unless the HTTP status code above is >= 500, please check your configuration for:
|
cc @edsantiago @mheon just an idea I had but I don't think it works as the client is killed before the server so I still try to figure out if I can switch the other somehow... |
I will cherrypick onto #17831 as soon as the current run finishes |
No point actually, this commit will do nothing. If we time-out in cleanup ginkgo panics and we do not get any further in Cleanup() as such we never call the server to stop and leak it. I need to rework the code quite a bit to make this work... |
To debug containers#22246 Signed-off-by: Paul Holzinger <[email protected]>
25a154b
to
c3453dd
Compare
Ok this version might be good enough, but looking at this I really need to fix the cleanup logic there. One command times out and we leak stuff... |
This seems to be the main cause of the hang, the pod listing hangs because the pod lock is taken by this currently. |
A friendly reminder that this PR had no activity for 30 days. |
To debug #22246, not sure if this will work. We likely kill the client before which means the connection is likely closed and we do not see the hang or whatever happens.
Does this PR introduce a user-facing change?