Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/api: do not leak config pointers into specgen #23428

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Jul 29, 2024

The value of the pointer might be changed while creating the container causing unexpected side effects.

Does this PR introduce a user-facing change?

None

The value of the pointer might be changed while creating the container
causing unexpected side effects.

Signed-off-by: Paul Holzinger <[email protected]>
Copy link
Contributor

openshift-ci bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2024
@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Jul 29, 2024
@mheon
Copy link
Member

mheon commented Jul 29, 2024

LGTM!

@Luap99 Luap99 added the 5.2 label Jul 29, 2024
@edsantiago
Copy link
Member

#21569 reproduces so conveniently in CI :-(

@mheon
Copy link
Member

mheon commented Jul 29, 2024

@containers/podman-maintainers PTAL and merge

@rhatdan
Copy link
Member

rhatdan commented Jul 29, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2316d91 into containers:main Jul 29, 2024
83 checks passed
@Luap99 Luap99 deleted the config-clone branch July 29, 2024 19:18
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 28, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
5.2 approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants