-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v5.1] Drop minikube CI test #23235
[v5.1] Drop minikube CI test #23235
Conversation
Signed-off-by: Chris Evich <[email protected]>
At the time of this commit, on main this task includes: ```yaml # 2024-05-21: flaking almost constantly since March. skip: $CI == $CI ``` Disable the test entirely on this branch due to multiple failures, difficulty debugging, lack of team expertise, and willpower to care. Ref: https://cirrus-ci.com/task/4712403315720192 Signed-off-by: Chris Evich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, fine for me to drop it from this branch.
/lgtm I'll need to rebase after this lands but that's fine |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I am going to force merge this as the wsl fix is in @mheon's PR and there is no need to respin both |
I'm happy to hear arguments for keeping this (and perhaps the one on main also?) and/or pointer at someone who is willing to debug and maintain it. Otherwise IMO this task is just a waste of resources.
--OR--
At the time of this commit, on main this task includes:
Disable the test entirely on this branch due to multiple failures, difficulty debugging, lack of team expertise, and willpower to care.
Ref: https://cirrus-ci.com/task/4712403315720192
Does this PR introduce a user-facing change?