Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5.1] Drop minikube CI test #23235

Merged
merged 2 commits into from
Jul 10, 2024
Merged

[v5.1] Drop minikube CI test #23235

merged 2 commits into from
Jul 10, 2024

Conversation

cevich
Copy link
Member

@cevich cevich commented Jul 9, 2024

I'm happy to hear arguments for keeping this (and perhaps the one on main also?) and/or pointer at someone who is willing to debug and maintain it. Otherwise IMO this task is just a waste of resources.


--OR--


At the time of this commit, on main this task includes:

    # 2024-05-21: flaking almost constantly since March.
    skip: $CI == $CI

Disable the test entirely on this branch due to multiple failures, difficulty debugging, lack of team expertise, and willpower to care.

Ref: https://cirrus-ci.com/task/4712403315720192

Does this PR introduce a user-facing change?

None

cevich added 2 commits July 9, 2024 11:44
At the time of this commit, on main this task includes:

```yaml
    # 2024-05-21: flaking almost constantly since March.
    skip: $CI == $CI
```

Disable the test entirely on this branch due to multiple failures,
difficulty debugging, lack of team expertise, and willpower to care.

Ref: https://cirrus-ci.com/task/4712403315720192

Signed-off-by: Chris Evich <[email protected]>
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fine for me to drop it from this branch.

@mheon
Copy link
Member

mheon commented Jul 9, 2024

/lgtm

I'll need to rebase after this lands but that's fine

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
@rhatdan
Copy link
Member

rhatdan commented Jul 10, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@Luap99
Copy link
Member

Luap99 commented Jul 10, 2024

I am going to force merge this as the wsl fix is in @mheon's PR and there is no need to respin both

@Luap99 Luap99 merged commit a5ba0a9 into containers:v5.1 Jul 10, 2024
84 of 87 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 9, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants