Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when machine memory exceeds system memory #23126

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

baude
Copy link
Member

@baude baude commented Jun 27, 2024

Close loophole that would allow you to assign more memory than the system has to a podman machine

Fixes: #18206

Does this PR introduce a user-facing change?

Fixed bug where user could assign more memory to a Podman machine than existed on the host.

@openshift-ci openshift-ci bot added release-note approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 27, 2024
utils/utils.go Outdated Show resolved Hide resolved
pkg/machine/e2e/init_test.go Outdated Show resolved Hide resolved
utils/utils.go Outdated Show resolved Hide resolved
Close loophole that would allow you to assign more memory than the
system has to a podman machine

Fixes: containers#18206

Signed-off-by: Brent Baude <[email protected]>
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jul 1, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024
Copy link
Contributor

openshift-ci bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, Luap99, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Luap99,baude,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 94ebb12 into containers:main Jul 1, 2024
88 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 30, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. machine release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman machine can be created with arbitrary big memory
3 participants