Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test c/storage with fix-depricated-hdr_Xattrs #23104

Closed
wants to merge 1 commit into from
Closed

Test c/storage with fix-depricated-hdr_Xattrs #23104

wants to merge 1 commit into from

Conversation

Honny1
Copy link
Member

@Honny1 Honny1 commented Jun 25, 2024 •
edited
Loading

Integration test for PR: c/storage#1985

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Jun 25, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Honny1
Once this PR has been reviewed and has the lgtm label, please assign ashley-cui for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Honny1 Honny1 force-pushed the test-fix-deprecated-hdr_Xattrs-in-c-storage branch from d3f9f50 to a2ffc7d Compare June 25, 2024 17:27
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2024
@Honny1 Honny1 mentioned this pull request Jun 26, 2024
Merged
Luap99
Luap99 reviewed Jun 26, 2024
View reviewed changes
go.mod Outdated
@@ -227,3 +227,5 @@ require (
)

replace github.com/opencontainers/runc => github.com/opencontainers/runc v1.1.1-0.20240131200429-02120488a4c0

replace github.com/containers/storage => github.com/Honny1/storage v0.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI you do not have to create tags on your fork.
The way to do this is to replace the tag with the branch name or commit sha and then just run make vendor. Go will figure it our from there and replace it with pseudo version, i.e.
github.com/containers/common v0.59.1-0.20240603155017-49ad520556e7

Copy link
Member Author

@Honny1 Honny1 Jun 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Honny1 Honny1 force-pushed the test-fix-deprecated-hdr_Xattrs-in-c-storage branch from a2ffc7d to 467f112 Compare June 26, 2024 11:48
@Honny1 Honny1 force-pushed the test-fix-deprecated-hdr_Xattrs-in-c-storage branch from 467f112 to 4cfd50e Compare June 26, 2024 16:08
@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@Honny1
Copy link
Member Author

Honny1 commented Jun 26, 2024

/packit rebuild-failed

@Honny1 Honny1 closed this Jun 27, 2024
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

Assignees
No one assigned
Labels
do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Honny1 @Luap99 @openshift-merge-robot