Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update golangci-lint to v1.59.0 #22815

Merged
merged 1 commit into from
May 27, 2024
Merged

update golangci-lint to v1.59.0 #22815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,10 @@ linters:
- nakedret
- gosmopolitan # usage of time.Local in pkg/k8s.io
- tagliatelle # too many JSON keys cannot be changed due to compat
- nosnakecase # too many false positives due to the `unix` package
- dupword # too many false positives (e.g., in tests)
- gocognit
- testpackage
- err113
- exhaustivestruct
- errorlint
- wrapcheck
- paralleltest
Expand All @@ -34,7 +32,6 @@ linters:
- nestif
- predeclared
- thelper
- ifshort
- forbidigo
- exhaustive
- gofumpt
Expand All @@ -48,7 +45,6 @@ linters:
- gocyclo
- lll
- gosec
- maligned
- musttag # way to many warnings to fix for now, also some false positives
- mnd # way to many false positives
- gomoddirectives
Expand All @@ -65,12 +61,6 @@ linters:
- nonamedreturns
- exhaustruct
# deprecated linters
- golint # replaced by revive
- scopelint # replaced by exportloopref
- interfacer
- deadcode # deprecated since v1.49.0, replaced by unused
- structcheck # deprecated since v1.49.0, replaced by unused
- varcheck # deprecated since v1.49.0, replaced by unused
- execinquery
linters-settings:
errcheck:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ BUILDTAGS += ${EXTRA_BUILDTAGS}
# N/B: This value is managed by Renovate, manual changes are
# possible, as long as they don't disturb the formatting
# (i.e. DO NOT ADD A 'v' prefix!)
GOLANGCI_LINT_VERSION := 1.58.2
GOLANGCI_LINT_VERSION := 1.59.0
PYTHON ?= $(shell command -v python3 python|head -n1)
PKG_MANAGER ?= $(shell command -v dnf yum|head -n1)
# ~/.local/bin is not in PATH on all systems
Expand Down
5 changes: 4 additions & 1 deletion pkg/util/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,10 @@ func ParseRegistryCreds(creds string) (*types.DockerAuthConfig, error) {
username, password := parseCreds(creds)
if username == "" {
fmt.Print("Username: ")
fmt.Scanln(&username)
_, err := fmt.Scanln(&username)
if err != nil {
return nil, fmt.Errorf("could not read username: %w", err)
}
}
if password == "" {
fmt.Print("Password: ")
Expand Down