-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExitWithError() - final push to strict mode #22690
ExitWithError() - final push to strict mode #22690
Conversation
Ephemeral COPR build failed. @containers/packit-build please check. |
Cockpit tests failed for commit f194bc459cc04a0aa89640f9ee54450a2e452e9a. @martinpitt, @jelly, @mvollmer please check. |
f194bc4
to
79cb62c
Compare
Ephemeral COPR build failed. @containers/packit-build please check. |
Cockpit tests failed for commit 79cb62c841216b086ebed0bcf4d2ef1d838510e8. @martinpitt, @jelly, @mvollmer please check. |
Signed-off-by: Ed Santiago <[email protected]>
Final followup to containers#22270. That PR added a temporary convention allowing a new form of ExitWithError(), one with an exit code and stderr substring. In order to allow bite-size progress, the old no-args form was still allowed. This PR removes support for no-args ExitWithError(). This PR also adds one piece of new functionality: passing "" (empty string) as the stderr arg means "expect exit code but fail if there's anything at all in stderr". Signed-off-by: Ed Santiago <[email protected]>
79cb62c
to
d4e40fe
Compare
Ephemeral COPR build failed. @containers/packit-build please check. |
Cockpit tests failed for commit d4e40fe. @martinpitt, @jelly, @mvollmer please check. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5044a0b
into
containers:main
Final followup to #22270. That PR added a temporary convention
allowing a new form of ExitWithError(), one with an exit code
and stderr substring. In order to allow bite-size progress,
the old no-args form was still allowed. This PR removes
support for no-args ExitWithError().
This PR also adds one piece of new functionality: passing ""
(empty string) as the stderr arg means "expect exit code
but fail if there's anything at all in stderr".
And, one small commit because I seem to have missed a few.