Add configuration for podmansh

[grisu48]

Use the configuration parameters from the newly introduced
PodmanshConfig struct. This allows podmansh to be configured via
configuration files.

Configuring the shell is a feature I require for my persistent user container project I'm currently working on, see also
https://lists.podman.io/archives/list/[email protected]/thread/VCVWFK37UGW434KNE46MDK6NOE6CPHRB/

Merge together with containers/common#1993 (merged)

Does this PR introduce a user-facing change?

Adds configuration options for the container name and shell in podmansh

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[mheon]

You have build failures. Possibly needs a new containers/common vendor?

[grisu48]

You have build failures. Possibly needs a new containers/common vendor?

Yes, this is together with containers/common#1993.

[grisu48]

containers/common#1993 is merged. Waiting for renovate to update the containers/common dependency then this can me merged as well.

[Luap99]

containers/common#1993 is merged. Waiting for renovate to update the containers/common dependency then this can me merged as well.

You can add second commit here that vendors c/common@main (needs to ensure the commit is before this one to ensure it builds correctly)

[grisu48]

containers/common#1993 is merged. Waiting for renovate to update the containers/common dependency then this can me merged as well.

You can add second commit here that vendors c/common@main (needs to ensure the commit is before this one to ensure it builds correctly)

Done. I've run a go get github.com/containers/common@79d954c7766303997d7dea4340442855e143fc5b with the last commit from https://github.com/containers/common/ and created a separate commit for the changes therein. Two additional repositories got updated, I assume because they are dependencies.

Please help me verify if this is correct.

[Luap99]

containers/common#1993 is merged. Waiting for renovate to update the containers/common dependency then this can me merged as well.

You can add second commit here that vendors c/common@main (needs to ensure the commit is before this one to ensure it builds correctly)

Done. I've run a go get github.com/containers/common@79d954c7766303997d7dea4340442855e143fc5b with the last commit from https://github.com/containers/common/ and created a separate commit for the changes therein. Two additional repositories got updated, I assume because they are dependencies.

Please help me verify if this is correct.

Yes this is correct and normal. The commit is missing theSigned-off-by line though.

[grisu48]

Yes this is correct and normal.

Thank you.

The commit is missing theSigned-off-by line though.

Fixed.

[Luap99]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grisu48, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Luap99]

@grisu48 FYI I pushed another commit to make the e2e tests pass

[grisu48]

@grisu48 FYI I pushed another commit to make the e2e tests pass

Thanks, LGTM!

[mheon]

Let's get this landed.
/lgtm
/cherry-pick v5.1

[openshift-cherrypick-robot]

@mheon: once the present PR merges, I will cherry-pick it on top of v5.1 in a new PR and assign it to you.

In response to this:

Let's get this landed.
/lgtm
/cherry-pick v5.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@mheon: #22683 failed to apply on top of branch "v5.1":

Applying: Update containers/common to latest main
.git/rebase-apply/patch:260: trailing whitespace.
# 
.git/rebase-apply/patch:263: trailing whitespace.
# 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update containers/common to latest main
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

Let's get this landed.
/lgtm
/cherry-pick v5.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[grisu48]

Thank you everyone 🥳