Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Add more annnotation information to podman kupe play man page #22424

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Apr 18, 2024

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 18, 2024
@rhatdan
Copy link
Member Author

rhatdan commented Apr 18, 2024

Help Document #22378 (reply in thread)

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link

Cockpit tests failed for commit 422eb0e. @martinpitt, @jelly, @mvollmer please check.

@rhatdan
Copy link
Member Author

rhatdan commented Apr 18, 2024

@cevich @umohnani8 Whay are testing-farm tests running on CI:DOCS PRs?

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link

Cockpit tests failed for commit 422eb0e. @martinpitt, @jelly, @mvollmer please check.

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@mheon
Copy link
Member

mheon commented Apr 18, 2024

LGTM

@umohnani8
Copy link
Member

I am not sure, might be a test configuration that you have to set to not run on these kind of PRs. @cevich do you know?

Changes LGTM

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Luap99
Copy link
Member

Luap99 commented Apr 18, 2024

@cevich @umohnani8 Whay are testing-farm tests running on CI:DOCS PRs?

Packit has no concept of our cirrus specific PR titles. It will always run everything (well at least by default, I am sure there are ways to configure what is run)

@openshift-merge-bot openshift-merge-bot bot merged commit 8b6ae87 into containers:main Apr 18, 2024
39 of 43 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jul 18, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants