[v5.0] fix swagger doc #22389
Merged
[v5.0] fix swagger doc #22389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jhon Honce <[email protected]>
First of all this removes the need for a network connection, second renovate can update the version as it is tracked in go.mod. However the real important part is that the binary downloads are broken[1]. For some reason the swagger created with them does not include all the type information for the examples. However when building from source the same thing works fine. [1] go-swagger/go-swagger#2842 Signed-off-by: Paul Holzinger <[email protected]>
Commit 668d517 moved a lot of type definitions and by that also copied a bucnh of swagger:model comments, this caused swagger to create a incorrect yaml that can no longer be parsed by redoc due "Self-referencing circular pointer". The yaml basically defined the type with a name and the pointed to the same name definition again so it caused a infinitive recursion where redoc just throws an error but the swagger style ignored the case so it seemed like it worked but obviously the type information was not working. Fixes containers#22351 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added
the
No New Tests
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
kind/api-change
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
/lgtm |
Luap99
added
the
approved
openshift-merge-bot
bot
merged commit 04d45be
into
containers:v5.0
90 of 92 checks passed
Closed
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #22357 to fix the swagger generation on the 5.0 branch.
Does this PR introduce a user-facing change?