[v5.0] Bump Buildah to v1.35.3 #22219
Conversation
As the title says, bumping to Buildah v1.35.3 in preparation of Podman v5.0.1 [NO NEW TESTS NEEDED] Signed-off-by: tomsweeneyredhat <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@mheon @ashley-cui PTAL |
|
@mheon the failures here look real, network related. Are there Podman changes that need to be backported too? |
|
see my mail, you need to grab my pasta fixes from https://github.com/containers/podman/pull/22079/commits |
By default we just ignored any localhost reolvers, this is problematic for anyone with more complicated dns setups, i.e. split dns with systemd-reolved. To address this we now make use of the build in dns proxy in pasta. As such we need to set the default nameserver ip now. A second change is the option to exclude certain ips when generating the host.containers.internal ip. With that we no longer set it to the same ip as is used in the netns. The fix is not perfect as it could mean on a system with a single ip we no longer add the entry, however given the previous entry was incorrect anyway this seems like the better behavior. Fixes containers#22044 [NO NEW TESTS NEEDED] Signed-off-by: Paul Holzinger <[email protected]>
Always teardown the network, trying to reuse the netns has caused a significant amount of bugs in this code here. It also never worked for containers with user namespaces. So once and for all simplify this by never reusing the netns. Originally this was done to have a faster restart of containers but with netavark now we are much faster so it shouldn't be that noticeable in practice. It also makes more sense to reconfigure the netns as it is likely that the container exited due some broken network state in which case reusing would just cause more harm than good. The main motivation for this change was the pasta change to use --dns-forward by default. As the restarted contianer had no idea what nameserver to use as pasta just kept running. [NO NEW TESTS NEEDED] Signed-off-by: Paul Holzinger <[email protected]> Signed-off-by: tomsweeneyredhat <[email protected]>
|
@Luap99 Thanks! I've just cherry-picked those two, fingers crossed on the tests. |
|
Different errors after the merge. Now it looks to be ssh proxy issues on the machine. |
|
machine tests are still flaky I think, I restarted them |
|
Restart got it, Woot! Thanks @Luap99 |
|
/lgtm |
openshift-merge-bot
bot
merged commit 1ecd7d0
into
containers:v5.0
stale-locking-app
bot
added
the
locked - please file new issue/PR
As the title says, bumping to Buildah v1.35.3 in preparation of Podman v5.0.1
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?