-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logformatter: handle Windows logs #22081
logformatter: handle Windows logs #22081
Conversation
C-colon and backslashes and ^Ms oh my Tested on sample failure and success logs, seems to work. Signed-off-by: Ed Santiago <[email protected]>
Cockpit tests failed for commit f16ab11. @martinpitt, @jelly, @mvollmer please check. |
@containers/podman-maintainers this is a NOP until #21991 merges, but having it merged might help Mario test & debug that PR when he gets back next week. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8bfe9e4
into
containers:main
C-colon and backslashes and ^Ms oh my
Tested on sample failure and success logs, seems to work.
Signed-off-by: Ed Santiago [email protected]