test: fix manifest e2e test assumption #21878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
giuseppe
force-pushed
the
fix-manifest-test-assumption
branch
from
b743ae4 to
2243de6
Compare
|
LGTM |
mtrmac
reviewed
Feb 29, 2024
test/e2e/manifest_test.go
Outdated
| @@ -16,6 +17,50 @@ import ( | |||
| imgspecv1 "github.com/opencontainers/image-spec/specs-go/v1" | |||
| ) | |||
|
|
|||
| // validateManifestHasAllArchs checks that the specified manifest has all | |||
| // the archs in `imageListInstance` | |||
There was a problem hiding this comment.
Suggested change
| // the archs in `imageListInstance` | |
| // the archs in `imageList` |
; imageListInstance seems to refer to the individual imageListARM64InstanceDigest platform.
Aesthetically I’d prefer this to be a neutral utility, with the list of expected architectures passed by the individual test as a parameter (and possibly an imageListAllArchitectures constant, near imageList, used to hold that value).
fix an assumption in the test, that the --compression-format is unchanged from the original image. Instead validate that all the required architectures are part of the manifest. Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
fix-manifest-test-assumption
branch
from
2243de6 to
c50826c
Compare
|
/lgtm |
|
LGTM |
|
Thanks again! |
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix an assumption in the test, that the --compression-format is unchanged from the original image.
Instead validate that all the required architectures are part of the manifest.
Does this PR introduce a user-facing change?